On Fri, 08 Apr 2016, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > VBT can only contain 16 panel entries, indexed with the panel_type. > To play it safe we should reject panel_type > 0xf, so that we don't > read past the valid data. > > Cc: Rob Kramer <rob@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_bios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c > index eb756c41d9e1..13bdd4316092 100644 > --- a/drivers/gpu/drm/i915/intel_bios.c > +++ b/drivers/gpu/drm/i915/intel_bios.c > @@ -212,7 +212,7 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv, > return; > > dev_priv->vbt.lvds_dither = lvds_options->pixel_dither; > - if (lvds_options->panel_type == 0xff) > + if (lvds_options->panel_type > 0xf) Debug logging on this? Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > return; > > panel_type = lvds_options->panel_type; -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
