Re: [PATCH 1/2] drm/i915: Use i915_vm_to_ppgtt instead of manual container_of

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 31, 2016 at 07:49:38PM +0300, Joonas Lahtinen wrote:
> As we have the function with error checking, use it.

However, that error checking turns up in the profiles for some GL
benchmarks. Crazy huh!

Note also that you missed an opportunity in
i915_gem_restore_gtt_mappins()

Please let's just treat the programmer with a little respect here.

If you kindly remove the WARN, then
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux