Re: [PATCH v2] drm/i915: Rename GGTT init functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 29, 2016 at 04:15:54PM +0300, Joonas Lahtinen wrote:
> On to, 2016-03-24 at 16:47 +0200, Joonas Lahtinen wrote:
> > Rename and document the GGTT init functions to give a better
> > idea of the context where they are called from.
> > 
> > i915_gem_gtt_init => i915_ggtt_init_hw
> > i915_gem_init_global_gtt => i915_gem_init_ggtt
> > i915_global_gtt_cleanup => i915_ggtt_cleanup_hw
> > 
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> 
> Chris, accidentally did not remove you A-b for v2. You can retake your
> position here.
> 
> This is the best balance between general naming logic and consistency
> with ppgtt I could come up. How about I merge this?

I don't have any better names to suggest, and the init_hw should help a
lot. Go for it.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux