Re: [PATCH 0/7] Add lspcon support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Regards
Shashank

On 3/23/2016 2:33 PM, Daniel Vetter wrote:
On Tue, Mar 22, 2016 at 10:17:36PM +0530, Sharma, Shashank wrote:
Thanks Ville.
I will have a look at the series you posted, and if that's the case, will
try to merge this implementation on top of yours.

Please try to review Ville's patches either way using the DP specs, so
that we can pull it in. You have to read it carefully anyway to figure out
whether it matches lspcon well enough, so might as well use that time ;-)

Thanks, Daniel

Got it :)

Regards
Shashank

On 3/22/2016 9:50 PM, Ville Syrjälä wrote:
On Tue, Mar 22, 2016 at 07:55:01PM +0530, Shashank Sharma wrote:
LSPCON is essentially an active DP-HDMI convertor. It has
two modes of operations:
- ls mode (for upto HDMI 1.4 outputs, 4k@30 resoution / 297MHz)
- pcon mode (for upto HDMI 2.0 outputs, 4k@60 resolution / 600 MHz)

This patch set adds support for LS mode of operation for GEN9
platforms. It adds a new connector for lspcon, whcih is a mix
and match of DP and HDMI connectors, matching dual personality
of lspcon devices.

Notes:
- Daniel Vetter gave a review comment on LSPCON design, to make
   it a separate encoder. This patch set tries to match that expectations
   with a separate connector, as DDI encoder already fulfills all the
   requirements of a lspcon_encoder.
- This patch set tagrets LS mode of operations only.
- PCON mode of operation will be added later, based on the requirements.
   This is to primarily unbloc Linux devices with LSPCON port.
- This patch set is tested with BXT RVP + drm-nightly
- As we redesigned this code, to meet the review comments, this is a working
   patch set, but not upto commercial quality yet.

Quick glance tells me this is more or less just an in driver implementation
of the DP dual mode standard at this point. I recently posted some patches [1]
that implement dual mode support as a helper. So you should check it out
and try to layer whatever lspcon specifics on top of that.

The only thing missing from my patches was basically using i2c-over-aux
instead of gmbus for type2 adapters, but that's mostly just a matter of
passing the right i2c adapter to places.

[1] https://lists.freedesktop.org/archives/dri-devel/2016-February/101494.html


Shashank Sharma (7):
   drm/i915: add lspcon vbt bit parsing
   drm/i915: Add lspcon data structures
   drm/i915: Add new lspcon file
   drm/i915: Add and initialize lspcon connector
   drm/i915: Add and register lspcon connector functions
   drm/i915: Add lspcon core functions
   drm/i915: Add lspcon hpd handler

  drivers/gpu/drm/i915/Makefile         |   3 +-
  drivers/gpu/drm/i915/i915_drv.h       |   1 +
  drivers/gpu/drm/i915/intel_bios.c     |  42 +++
  drivers/gpu/drm/i915/intel_ddi.c      |   6 +
  drivers/gpu/drm/i915/intel_dp.c       |  31 ++
  drivers/gpu/drm/i915/intel_drv.h      |  35 +-
  drivers/gpu/drm/i915/intel_hdmi.c     |  25 +-
  drivers/gpu/drm/i915/intel_hotplug.c  |   2 +-
  drivers/gpu/drm/i915/intel_lspcon.c   | 620 ++++++++++++++++++++++++++++++++++
  drivers/gpu/drm/i915/intel_vbt_defs.h |   1 +
  10 files changed, 759 insertions(+), 7 deletions(-)
  create mode 100644 drivers/gpu/drm/i915/intel_lspcon.c

--
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux