On Tue, Mar 22, 2016 at 06:31:53PM +0200, Jani Nikula wrote: > On Tue, 22 Mar 2016, Imre Deak <imre.deak@xxxxxxxxx> wrote: > > [ text/plain ] > > On ti, 2016-03-22 at 08:56 -0700, Matt Roper wrote: > >> On Tue, Mar 22, 2016 at 04:17:58PM +0200, Imre Deak wrote: > >> > On ti, 2016-03-22 at 15:51 +0200, Jani Nikula wrote: > >> > > On Tue, 22 Mar 2016, Imre Deak <imre.deak@xxxxxxxxx> wrote: > >> > > > [ text/plain ] > >> > > > On ti, 2016-03-08 at 09:26 -0800, Matt Roper wrote: > >> > > > > On Mon, Mar 07, 2016 at 11:47:51AM +0000, Patchwork wrote: > >> > > > > > == Series Details == > >> > > > > > > >> > > > > > Series: drm/i915: Wait until after wm optimization to drop > >> > > > > > runtime > >> > > > > > PM reference > >> > > > > > URL : https://patchwork.freedesktop.org/series/4135/ > >> > > > > > State : failure > >> > > > > > > >> > > > > > == Summary == > >> > > > > > > >> > > > > > Series 4135v1 drm/i915: Wait until after wm optimization to > >> > > > > > drop > >> > > > > > runtime PM reference > >> > > > > > http://patchwork.freedesktop.org/api/1.0/series/4135/revisi > >> > > > > > ons/ > >> > > > > > 1/mb > >> > > > > > ox/ > >> > > > > > > >> > > > > > Test kms_flip: > >> > > > > > Subgroup basic-flip-vs-wf_vblank: > >> > > > > > fail -> PASS (bsw-nuc-2) > >> > > > > > Subgroup basic-plain-flip: > >> > > > > > dmesg-warn -> PASS (hsw-gt2) > >> > > > > > Test kms_force_connector_basic: > >> > > > > > Subgroup force-load-detect: > >> > > > > > pass -> SKIP (ivb-t430s) > >> > > > > > >> > > > > https://bugs.freedesktop.org/show_bug.cgi?id=93769 > >> > > > > > >> > > > > > Test kms_pipe_crc_basic: > >> > > > > > Subgroup read-crc-pipe-c: > >> > > > > > dmesg-warn -> PASS (hsw-gt2) > >> > > > > > Subgroup suspend-read-crc-pipe-a: > >> > > > > > dmesg-warn -> PASS (skl-i5k-2) > >> > > > > > skip -> PASS (hsw-brixbox) > >> > > > > > Subgroup suspend-read-crc-pipe-c: > >> > > > > > pass -> DMESG-WARN (bsw-nuc-2) > >> > > > > > >> > > > > https://bugs.freedesktop.org/show_bug.cgi?id=93294 > >> > > > > > >> > > > > > pass -> INCOMPLETE (hsw-gt2) > >> > > > > > >> > > > > Seems like the machine just died completely? No > >> > > > > stdout/stderr/command/dmesg output available from CI and time > >> > > > > is > >> > > > > given > >> > > > > as 0:00:00. Doesn't seem like it could be related to this > >> > > > > patch. > >> > > > > > >> > > > > > >> > > > > > Test pm_rpm: > >> > > > > > Subgroup basic-pci-d3-state: > >> > > > > > dmesg-warn -> PASS (snb-dellxps) > >> > > > > > Subgroup basic-rte: > >> > > > > > pass -> DMESG-WARN (bsw-nuc-2) > >> > > > > > >> > > > > https://bugs.freedesktop.org/show_bug.cgi?id=94164 > >> > > > > > >> > > > > > >> > > > > Matt > >> > > > > >> > > > Pushed to -dinq, thanks for the patch and the review. > >> > > > > >> > > > I had to rebase it on top of Ville's recent > >> > > > s/crtc_state/old_crtc_state/ change, please double check it. > >> > > > > >> > > > Jani, this is for -fixes. > >> > > > >> > > Surely you added either > >> > > > >> > > Cc: drm-intel-fixes@xxxxxxxxxxxxxxxxxxxxx > >> > > > >> > > or > >> > > > >> > > Cc: stable@xxxxxxxxxxxxxxx > >> > > > >> > > in the commit when you pushed, then? > >> > > >> > No, I haven't will do that in the future. Btw, what's the rule for > >> > deciding that something is for -fixes or stable only after it's > >> > been > >> > pushed? Just ping you in case for -fixes and resend it in case of > >> > stable? > >> > > >> > --Imre > >> > >> Are you sure we need this for -fixes? The patch that introduced the > >> regression isn't in drm-next/4.6 as far as I know. > > > > The regressing commit ed4a6a7ca853 is in drm-intel-next, so I think we > > do need it for -fixes. > > Ah. It's not in 4.5 and it's not on its way to 4.6. Not fixes material. For the future: $ dim tag-contains $commit_that_youre_fixing Will tell you either the kernel version of if it hasn't landed, the branches. And if it's in airlied/drm-next but dinq is already past the merge window then it needs Cc: stable. If it's only in dinq then not. I guess we could improve the heuristics of the script a bit and directly print out the Cc: stable or Cc: drm-intel-fixes line you would need, if any ... Volunteers highly welcome ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
