On Mon, 21 Mar 2016, Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> wrote:
> +enum fb_mmap_wa_flags {
> + FB_MMAP_WA_CPU = 1 << 0,
> + FB_MMAP_WA_GTT = 1 << 1,
> + FB_MMAP_WA_DISABLE = 1 << 2,
> + FB_MMAP_WA_FLAG_COUNT = 3,
> +};
Drive-by review, adding bit flags as enums doesn't feel like what enums
should be used for. I'd go for macros instead.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
