On Fri, Mar 18, 2016 at 03:00:56PM +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > This anonymous struct was causing a good amount of overly > verbose code. Also, if we name it and cache the pointer locally > when there are multiple accesses to it, not only the code is > more readable, but the compiler manages to generate smaller > binary. > > Along the way I also shortened access to dev_priv and eliminated > some unused variables and cached some where I spotted the > opportunity. > > Name for the structure, intel_context_engine, and the local > variable name were borrowed from a similar patch by Chris Wilson. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Looks like a patch I've been maintaining for an eon, and I think Mika once did a similar thing. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> If I'm far enough away from it to be impartial? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
