Re: [PATCH] drm/i915: simplify bind_to_vm init code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17/03/16 13:41, Matthew Auld wrote:
Hi,

If we don't do any of the fence business for !i915_is_gtt, then will
this not change the following code:

if (alignment == 0)
     alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment;

Or am I missing something?

No I missed that bit. In which case your cleanup looks OK to me in principle. I would just not use obj_size since it is not that. Perhaps just reuse the existing size variable to hold the intermediate result?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux