On Tue, Mar 15, 2016 at 09:28:34AM +0000, Chris Wilson wrote: > On Tue, Mar 15, 2016 at 10:34:02AM +0200, Joonas Lahtinen wrote: > > On ma, 2016-03-14 at 16:59 +0200, Imre Deak wrote: > > > +module_param_named(inject_load_failure, i915.inject_load_failure, > > > uint, 0600); > > > > This most definitely should be module_param_named_unsafe. > > > > I think I'd also hope to see some kind of compile time option to enable > > this. I don't think average user wants this by default. > > That's not a bad idea. We can get rid of most of the dangerous params > this way. On the other hand, we need to keep the debug/quirk params > around so that we can test options in the wild (bug reporters). Yeah, most of the _unsafe stuff is _really_ useful for quick bug triage. Definitely don't want to disable those by default. Maybe an i915.fry_my_kernel option? But even that is too confusing I think for testers. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
