On 10/03/16 16:43, Arun Siluvery wrote:
On 10/03/2016 16:28, Tvrtko Ursulin wrote:
Hi,
On 10/03/16 15:00, Arun Siluvery wrote:
On 10/03/2016 14:21, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
I think there is consesus to do this, but the question
is whether now is the time to do it?
If desired, needs to go in quickly before it goes stale.
But if not, it was an interesting exercise of learning
Coccinelle nevertheless.
Tvrtko Ursulin (5):
drm/i915: Rename local struct intel_engine_cs variables
drm/i915: Rename intel_engine_cs function parameters
drm/i915: Rename intel_engine_cs struct members
drm/i915: More intel_engine_cs renaming
drm/i915: More renaming of rings to engines
drivers/gpu/drm/i915/i915_cmd_parser.c | 122 +--
drivers/gpu/drm/i915/i915_debugfs.c | 229 +++--
drivers/gpu/drm/i915/i915_dma.c | 12 +-
drivers/gpu/drm/i915/i915_drv.h | 70 +-
drivers/gpu/drm/i915/i915_gem.c | 316 +++---
drivers/gpu/drm/i915/i915_gem_context.c | 168 +--
drivers/gpu/drm/i915/i915_gem_debug.c | 15 +-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 120 +--
drivers/gpu/drm/i915/i915_gem_gtt.c | 94 +-
drivers/gpu/drm/i915/i915_gem_render_state.c | 12 +-
drivers/gpu/drm/i915/i915_gem_render_state.h | 2 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 158 +--
drivers/gpu/drm/i915/i915_guc_submission.c | 37 +-
drivers/gpu/drm/i915/i915_irq.c | 243 ++---
drivers/gpu/drm/i915/i915_trace.h | 6 +-
drivers/gpu/drm/i915/intel_display.c | 114 +--
drivers/gpu/drm/i915/intel_guc_loader.c | 12 +-
drivers/gpu/drm/i915/intel_lrc.c | 826 ++++++++-------
drivers/gpu/drm/i915/intel_lrc.h | 16 +-
drivers/gpu/drm/i915/intel_mocs.c | 6 +-
drivers/gpu/drm/i915/intel_overlay.c | 60 +-
drivers/gpu/drm/i915/intel_pm.c | 38 +-
drivers/gpu/drm/i915/intel_ringbuffer.c | 1425
+++++++++++++-------------
drivers/gpu/drm/i915/intel_ringbuffer.h | 86 +-
drivers/gpu/drm/i915/intel_uncore.c | 4 +-
25 files changed, 2132 insertions(+), 2059 deletions(-)
Are the filenames also going to be renamed?
I can't spot any files to rename, which ones you had in mind?
I mean intel_ringbuffer.c -> intel_engine.c ? or may not be necessary.
I would leave it since everyone calls the it legacy ringbuffer
submission, so it makes sense for it to implemented in an adequately
named file.
In fact I have second thoughts on a couple renames I did in 5/5, should
probably undo them.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
