Here's an updated patch series with Maarten's comments addressed. The last two patches also have fixes to please the state checker. Thanks, Ander Ander Conselvan de Oliveira (13): drm/i915: Move shared dpll code to a new file drm/i915: Move ddi shared dpll code to intel_dpll_mgr.c drm/i915: Split intel_get_shared_dpll() into smaller functions drm/i915: Store a direct pointer to shared dpll in intel_crtc_state drm/i915: Move shared dpll struct definitions to separate header file drm/i915: Move shared dpll function prototypes to intel_dpll_mgr.h drm/i915: Use a table to initilize shared dplls drm/i915: Refactor platform specifics out of intel_get_shared_dpll() drm/i915: Move HSW/BDW pll selection logic to intel_dpll_mgr.c drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c drm/i915: Move BXT pll configuration logic to intel_dpll_mgr.c drm/i915: Manage HSW/BDW LCPLLs with the shared dpll interface drm/i915: Make SKL/KBL DPLL0 managed by the shared dpll code drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h | 77 +- drivers/gpu/drm/i915/intel_crt.c | 8 +- drivers/gpu/drm/i915/intel_ddi.c | 1200 +--------------------- drivers/gpu/drm/i915/intel_display.c | 501 ++-------- drivers/gpu/drm/i915/intel_dp.c | 73 +- drivers/gpu/drm/i915/intel_dp_mst.c | 4 - drivers/gpu/drm/i915/intel_dpll_mgr.c | 1774 +++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dpll_mgr.h | 164 +++ drivers/gpu/drm/i915/intel_drv.h | 17 +- drivers/gpu/drm/i915/intel_lvds.c | 2 +- 11 files changed, 2055 insertions(+), 1766 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dpll_mgr.c create mode 100644 drivers/gpu/drm/i915/intel_dpll_mgr.h -- 2.4.3 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx