Hi Takashi, > -----Original Message----- > From: Takashi Iwai [mailto:tiwai@xxxxxxx] > Sent: Wednesday, March 02, 2016 4:57 PM > To: Yang, Libin > Cc: libin.yang@xxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; > conselvan2@xxxxxxxxx; jani.nikula@xxxxxxxxxxxxxxx; > ville.syrjala@xxxxxxxxxxxxxxx; Vetter, Daniel > Subject: Re: [PATCH] drm/i915: add audio_ptr pointer check > > On Wed, 02 Mar 2016 08:59:23 +0100, > Yang, Libin wrote: > > > > Hi Takashi, > > > > > -----Original Message----- > > > From: Takashi Iwai [mailto:tiwai@xxxxxxx] > > > Sent: Wednesday, March 02, 2016 3:44 PM > > > To: libin.yang@xxxxxxxxxxxxxxx > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; conselvan2@xxxxxxxxx; > > > jani.nikula@xxxxxxxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx; Vetter, > Daniel; > > > tiwai@xxxxxxx; Yang, Libin > > > Subject: Re: [PATCH] drm/i915: add audio_ptr pointer check > > > > > > On Wed, 02 Mar 2016 03:24:31 +0100, > > > libin.yang@xxxxxxxxxxxxxxx wrote: > > > > > > > > From: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > > > > > > > check to make sure audio_ptr is not NULL before > > > > using it. > > > > > > I don't think non-NULL is mandatory. If any invalid access is seen, > > > it should be fixed rather in the audio side. > > > > When I enable MST with other patches (not submitted so far), > > I found system may be random hang when boot up. > > > > After apply this patch and another patch (I sent the patch in > > ALSA Mail list: ALSA: hda - hdmi defer to register acomp eld notifier), > > the hang issue is fixed. > > > > I make the patch because in sound driver side, setting audio_ptr and > > audio_ops is not in the lock. I'm wondering that the compiler or CPU > > may optimize and change the setting order (the gfx code and alsa code > > may run parallelly?). > > There are several ways to deal with such a thing. An easy one would > be the memory barrier. Yes, agree to use mb. It will be easier and safer. I think wmb() should be enough for this case, right? I will do the stress test on mb. Regards, Libin > > > Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
