On Wed, Mar 02, 2016 at 02:22:58PM +0000, Daniel Stone wrote: > On Wed, 2016-03-02 at 14:21 +0000, Chris Wilson wrote: > > On Wed, Mar 02, 2016 at 03:00:14PM +0100, Tomeu Vizoso wrote: > > > @@ -1006,8 +1019,9 @@ static cairo_surface_t *get_cairo_surface(int > > > fd, struct igt_fb *fb) > > > create_cairo_surface__gtt(fd, fb); > > > } > > > > > > - gem_set_domain(fd, fb->gem_handle, > > > - I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU); > > > + if (!fb->is_dumb) > > > + gem_set_domain(fd, fb->gem_handle, > > > I915_GEM_DOMAIN_CPU, > > > + I915_GEM_DOMAIN_CPU); > > At the risk of opening a can-of-worms, what is the synchronisation > > protocol for dumb buffers? Even CPU access to a dumb needs set-domain > > on > > Intel. > > Then Intel is broken, because the literal entire point of dumb buffers > is that you do not require driver-specific calls to operate them. > > Map, populate, unmap, display. Don't forget to call dirtyfb then. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
