Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
> This fixes the IGT test, which interprets unknown status as failed to
> acquire load detect pipe.

Change the expectation of the test?

But more importantly, how can it fail to find a pipe when there's
kmstest_unset_all_crtcs() in the test?

> 
> Cc: Gabriel Feceoru <gabriel.feceoru@xxxxxxxxx>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_crt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index 505fc5cf26f8..4b2dfa1bb00e 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -652,6 +652,8 @@ intel_crt_detect(struct drm_connector *connector, bool force)
>  		else if (INTEL_INFO(dev)->gen < 4)
>  			status = intel_crt_load_detect(crt,
>  				to_intel_crtc(connector->state->crtc)->pipe);
> +		else if (i915.load_detect_test)
> +			status = connector_status_disconnected;
>  		else
>  			status = connector_status_unknown;
>  		intel_release_load_detect_pipe(connector, &tmp, &ctx);
> -- 
> 2.1.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux