Op 29-02-16 om 22:06 schreef Zanoni, Paulo R: > Em Seg, 2016-02-29 às 10:58 +0100, Maarten Lankhorst escreveu: >> Whenever there's an update to the primary plane, >> fbc_pre_update and fbc_post_update are called. Kill off >> intel_crtc->atomic.update_fbc and now that intel_crtc->atomic >> is empty, kill it off too. >> >> Changes since v1: >> - Add a intel_fbc_supports_rotation helper. >> Changes sinec v2: >> - Remove intel_fbc_supports_rotation_helper. >> - Remove unrelated changes. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >> --- >> This version doesn't change intel_fbc_enable any more! > Ok, so I decided to test this. > > First of all, patch 05 needs a rebase too. I did my own local rebase > and I suppose I got things right. > > Second, after I did actual testing, I discovered that, contrary to my > previous belief, "old_pri_state" will also be valid when we're only > changing the sprite or cursor planes. So if we apply this patch, we'll > be calling pre_update+enable+post_update for every plane/cursor > enable/disable operation, which is not what we want since these are > unnecessary calls, as FBC only deals with the primary plane. I think we > need to fix this. This is a bug addressed by the next patch. drm/i915: Do not compute watermarks on a noop. I'll send the improved version for that. I didn't do it yet because I was waiting for the ILK wm patch to land. ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
