On Thu, Feb 18, 2016 at 10:31:37AM -0800, yu.dai@xxxxxxxxx wrote: > From: Alex Dai <yu.dai@xxxxxxxxx> > > There are several places inside driver where a GEM object is mapped to > kernel virtual space. The mapping is either done for the whole object > or certain page range of it. > > This patch introduces a function i915_gem_object_vmap to do such job. > > v2: Use obj->pages->nents for iteration within i915_gem_object_vmap; > break when it finishes all desired pages. The caller need to pass > in actual page number. (Tvrtko Ursulin) Who owns the pages? vmap doesn't increase the page refcount nor mapcount, so it is the callers responsibility to keep the pages alive for the duration of the vmapping. I suggested i915_gem_object_pin_vmap/unpin_vmap for that reason and that also provides the foundation for undoing one of the more substantial performance regressions from vmap_batch(). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
