On Tue, Feb 16, 2016 at 01:18:12PM +0200, Jani Nikula wrote: > We've given write permissions to dynamically change some module > parameters through /sys/module/i915/parameters although they only > support setting on module load. Fix the permissions. > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/i915/i915_params.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 8b9f36814165..b01245751086 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -92,7 +92,7 @@ MODULE_PARM_DESC(enable_fbc, > "Enable frame buffer compression for power savings " > "(default: -1 (use per-chip default))"); > > -module_param_named_unsafe(lvds_channel_mode, i915.lvds_channel_mode, int, 0600); > +module_param_named_unsafe(lvds_channel_mode, i915.lvds_channel_mode, int, 0400); > MODULE_PARM_DESC(lvds_channel_mode, > "Specify LVDS channel mode " > "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)"); > @@ -102,7 +102,7 @@ MODULE_PARM_DESC(lvds_use_ssc, > "Use Spread Spectrum Clock with panels [LVDS/eDP] " > "(default: auto from VBT)"); > > -module_param_named_unsafe(vbt_sdvo_panel_type, i915.vbt_sdvo_panel_type, int, 0600); > +module_param_named_unsafe(vbt_sdvo_panel_type, i915.vbt_sdvo_panel_type, int, 0400); > MODULE_PARM_DESC(vbt_sdvo_panel_type, > "Override/Ignore selection of SDVO panel mode in the VBT " > "(-2=ignore, -1=auto [default], index in VBT BIOS table)"); > @@ -130,7 +130,7 @@ module_param_named_unsafe(enable_psr, i915.enable_psr, int, 0600); > MODULE_PARM_DESC(enable_psr, "Enable PSR " > "(0=disabled [default], 1=enabled - link mode chosen per-platform, 2=force link-standby mode, 3=force link-off mode)"); > > -module_param_named_unsafe(preliminary_hw_support, i915.preliminary_hw_support, int, 0600); > +module_param_named_unsafe(preliminary_hw_support, i915.preliminary_hw_support, int, 0400); > MODULE_PARM_DESC(preliminary_hw_support, > "Enable preliminary hardware support."); > > @@ -164,7 +164,7 @@ MODULE_PARM_DESC(invert_brightness, > "to dri-devel@xxxxxxxxxxxxxxxxxxxxx, if your machine needs it. " > "It will then be included in an upcoming module version."); > > -module_param_named(disable_display, i915.disable_display, bool, 0600); > +module_param_named(disable_display, i915.disable_display, bool, 0400); > MODULE_PARM_DESC(disable_display, "Disable display (default: false)"); > > module_param_named_unsafe(disable_vtd_wa, i915.disable_vtd_wa, bool, 0600); > -- > 2.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
