Re: [PATCH i-g-t] tests/prime_mmap: Encapsulate check_for_dma_buf_mmap() in igt_fixture.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 12, 2016 at 03:32:30PM +0200, Marius Vlad wrote:
> This unbreaks distcheck target that in turn runs each test with --list-subtests.
> 
> Signed-off-by: Marius Vlad <marius.c.vlad@xxxxxxxxx>
> ---
>  tests/prime_mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c
> index 29a0cfd..1ea61c2 100644
> --- a/tests/prime_mmap.c
> +++ b/tests/prime_mmap.c
> @@ -504,10 +504,10 @@ igt_main
>  
>  	igt_fixture {
>  		fd = drm_open_driver(DRIVER_INTEL);
> +		igt_skip_on((check_for_dma_buf_mmap() != 0));
>  		errno = 0;
>  	}
>  
> -	igt_skip_on((check_for_dma_buf_mmap() != 0));

Definitely need to put anythign that looks at the hw/driver into
igt_fixture.

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>  
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
>  		igt_subtest(tests[i].name)
> -- 
> 2.7.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux