Re: [PATCH v3] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/16 09:33, Chris Wilson wrote:
On Fri, Feb 05, 2016 at 02:56:51PM -0800, Rodrigo Vivi wrote:
On Fri, Feb 5, 2016 at 11:31 AM, Dave Gordon <david.s.gordon@xxxxxxxxx> wrote:
@@ -907,7 +927,8 @@ int intel_logical_ring_reserve_space(struct drm_i915_gem_request *request)
          * adding any commands to it then there might not actually be
          * sufficient room for the submission commands.
          */
-       intel_ring_reserved_space_reserve(request->ringbuf, MIN_SPACE_FOR_ADD_REQUEST);
+       intel_ring_reserved_space_reserve(request->ringbuf,
+                       MIN_SPACE_FOR_ADD_REQUEST + WA_TAIL_DWORDS);

This should already be included in the MIN_SPACE_FOR_ADD_REQUEST as that
value is universal (and is adequate for the moment).
-Chris

I didn't put it there because we needed the extra space at present, but rather so that people changing either of those two values would be more likely to think about whether there were any unexpected interactions.

.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux