Daniel Stone <daniel@xxxxxxxxxxxxx> writes:
> Hi,
>
> On 3 February 2016 at 21:41, Eric Anholt <eric@xxxxxxxxxx> wrote:
>> + ret = ioctl(fd, DRM_IOCTL_VC4_WAIT_BO, &arg);
>> + igt_assert(ret == -1 && errno == EINVAL);
>
> A couple of nitpicks: all these should be either do_ioctl() for
> success, or do_ioctl_err() for failure, which not only cuts down the
> number of lines a bit, but also shows you the exact condition which
> occurred (e.g. it'll show that errno was -EBUSY rather than expected
> -EINVAL without having to round-trip through the reporter). Similarly,
> all your igt_assert(x == y) should be igt_assert_eq(x, y), or any of
> the igt_assert_{eq,neq} variants, e.g. _u32 for comparing uint32_t.
> You can also use do_or_die(foo) as shorthand for igt_assert_eq(foo,
> 0).
>
> With those addressed:
> Reviewed-by: Daniel Stone <daniels@xxxxxxxxxxxxx>
I converted everything but one of the ones in wait_bo, and pushed the
updated series to the vc4 branch of my tree. I'll give it another
couple of days in case anyone else has review to do on the series.
Thanks!
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
