On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: > On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" <sivakumar.thulasimani@xxxxxxxxx> wrote: > > just realized that intel_dsi_init is not called from setup outputs for > > BXT. is this expected ? > > if so when is it expected to be added ? > > > > Again, the current code in intel_setup_outputs calls intel_dsi_init from > > vlv/chv section so please confirm if this is needed for all platforms > > or just in BXT. > > Good (and embarrassing) catch! > > This may uncover more problems, since apparently we haven't been truly > controlling DSI ourselves, but it's just what's set up by the GOP. Ugh. > > Do you have it in your tree? > > Mika, please try adding intel_dsi_init() call to the IS_BROXTON() branch > of intel_setup_outputs(). It shouldn't matter whether it's before or > after the ddi init calls, as the VBT should (fingers crossed) contain > the right port info. > I have this in my tree. I assume that you are referring to this patch? https://patchwork.freedesktop.org/patch/58446/ -Mika- > > BR, > Jani. > > > > > > > > On 2/2/2016 11:21 PM, Ramalingam C wrote: > >> We need to enable DSI PLL before configuring the DSI registers. > >> > >> Signed-off-by: Ramalingam C <ramalingam.c@xxxxxxxxx> > >> --- > >> drivers/gpu/drm/i915/intel_dsi.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c > >> index 91cef35..378f879 100644 > >> --- a/drivers/gpu/drm/i915/intel_dsi.c > >> +++ b/drivers/gpu/drm/i915/intel_dsi.c > >> @@ -478,8 +478,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder) > >> > >> DRM_DEBUG_KMS("\n"); > >> > >> - intel_dsi_prepare(encoder); > >> intel_enable_dsi_pll(encoder); > >> + intel_dsi_prepare(encoder); > >> > >> /* Panel Enable over CRC PMIC */ > >> if (intel_dsi->gpio_panel) > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
