On su, 2016-01-31 at 16:20 -0800, Matt Roper wrote: > On Thu, Jan 28, 2016 at 04:04:12PM +0200, Imre Deak wrote: > > Add PCIIDs for new versions of the SOC, based on BSpec. Also add > > the > > name of the versions as code comment where this is available. The > > new > > versions don't have any changes visible to the kernel driver. > > > > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > > --- > > include/drm/i915_pciids.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index f970209..9b48ac1 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -296,7 +296,9 @@ > > #define INTEL_BXT_IDS(info) \ > > INTEL_VGA_DEVICE(0x0A84, info), \ > > INTEL_VGA_DEVICE(0x1A84, info), \ > > - INTEL_VGA_DEVICE(0x5A84, info) > > + INTEL_VGA_DEVICE(0x1A85, info), \ > > I don't see 0x1A85 in the bspec (at least not in the "Configurations > -> > Steppings and Device IDs" section...is there another list elsewhere > in > the bspec you got it from?) Hm yes, it looks like it was left out from the first table, it is only listed under "Broxton SKUs and Device IDs". I opened a new issue on the relevant BSpec page. > Semi-related...the revision ID vs stepping info on that page doesn't > seem to quite match what we have in bxt_stepping_info[] in > intel_csr.c Hm good point. This depends on how the firmware versions will be packaged for the newer versions. It is possible that for the new steppings a default entry will be used, in which case we wouldn't have to encode the individual steppings. +Animesh. Animesh could you check the above and follow-up with a patch updating the table if necessary? > (plus it looks like we have some new revision ID's we could add in > general). The way we did this so far is to add encodings only for steppings that we need for a WA. There hasn't been any need for the newer steppings based on this. --Imre > Matt > > > + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ > > \ > > + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */ > > > > #define INTEL_KBL_GT1_IDS(info) \ > > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > > -- > > 2.5.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
