On Fri, Jan 29, 2016 at 07:19:28PM +0000, Dave Gordon wrote: > The kunmap() call here didn't match the corresponding kmap(). > The kmap()ing was changed with the introduction of the GuC-compatible > layout of context objects and the introduction of "LRC_PPHWSP_PN", in > > d167519 drm/i915: Integrate GuC-based command submission > > but the corresponding kunmap() wasn't, probably because the old code > dug into the underlying sgl implementation instead of than calling > "i915_gem_object_get_page(ring->status_page.obj, 0)", which might more > easily have been noticed as containing an assumption about page 0. > > v3: > Use kmap_to_page() rather than repeat the mapping calculation. > [Chris Wilson] > > Signed-off-by: Dave Gordon <david.s.gordon@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> I think we are going end up with a kummap_addr() feature request, we have a handful of sites where we reconstruct the orginal page. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
