Re: [PATCH v2] Fix pointer tests in error-handling paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/01/16 12:33, Maarten Lankhorst wrote:
Hey,

Op 25-01-16 om 18:57 schreef Dave Gordon:
In the error-handling paths of i915_gem_do_execbuffer() and
intel_crtc_page_flip(), the local pointer-to-request variables
were expected to be either valid pointers or NULL. Since

   2682708 drm/i915: simplify allocation of driver-internal requests

they could also be ERR_PTR() values, so the tests need to be
updated to accommodate this case.

v2:    Added testcase (Chris Wilson)

Testcase: igt/gem_close_race
Signed-off-by: Dave Gordon <david.s.gordon@xxxxxxxxx>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
The testcase you mentioned doesn't work, it crashes on my machine instead of running to completion or triggering the bug.

It worked for me but I think I was running with GuC enabled at the time so that might be the differenct.

gem_close_race in general worked for me just yesterday.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux