Re: [PATCH v2] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13/01/16 19:11, Dave Gordon wrote:
On 13/01/16 19:01, yu.dai@xxxxxxxxx wrote:
From: Alex Dai <yu.dai@xxxxxxxxx>

During driver unloading, the guc_client created for command submission
needs to be released to avoid memory leak.

The struct_mutex needs to be held before tearing down GuC.

v1: Move i915_guc_submission_disable out of i915_guc_submission_fini and
     take struct_mutex lock before release GuC client. (Dave Gordon)
v2: Add the locking for failure case in guc_fw_fetch. (Dave Gordon)
     Add i915_guc_submission_fini for failure case in
intel_guc_ucode_load.

Signed-off-by: Alex Dai <yu.dai@xxxxxxxxx>

LGTM.

Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx>

Patch merged, thanks!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux