Re: [PATCH v5 1/1] drm/i915/bxt: Check BIOS RC6 setup before enabling RC6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 15, 2016 at 04:44:46PM +0200, Imre Deak wrote:
> Adding Chris. We would need stolen_base and size early, could you check
> if moving i915_gem_init_stolen() earlier based on the diff at the end
> is ok?

Had a quick discussion with Imre on irc, and yes this is fine. Though we
could move gem_init_stolen even earlier, into i915_gem_gtt_init() or
just after. I favour gtt_init since the stolen arena is closely coupled
with the gtt probing in i915_gem_gtt_init().

Also intel_setup_mchbar() is semantically related to our
dev_priv->regs = pci_iomap(), and I would suggest a new
intel_setup_mmio() to do both, nice and early.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux