Re: [PATCH 1/2] drm/i915/gen8: Tidy display interrupt processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2016 at 04:04:06PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> One bugfix and a few tidy-ups:
> 
>  * Pipe fault logging was broken on Gen9+.
>  * Removed some unnecessary local variables.
>  * Removed unnecessary initializers.
>  * Decreased pipe iir block indentation level.
>  * Grouped variable initialization close to use sites.

Out of curiosity did the compiled output change from the changes in
local variables? I'd slap a much-appreciated-by on anything that could
reduce the instruction count in our interrupt handlers!

Didn't spot any mistakes, so

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxx>

but I'd like to give some extra credit if you have shrunk this beast.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux