On Tue, Jan 12, 2016 at 11:34:45AM +0000, John Harrison wrote: > On 11/01/2016 22:24, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 06:42:50PM +0000, John.C.Harrison@xxxxxxxxx wrote: > >>From: John Harrison <John.C.Harrison@xxxxxxxxx> > >> > >>It can be useful to be able to disable certain features (e.g. the > >>entire scheduler) via a module parameter for debugging purposes. A > >>parameter has the advantage of not being a compile time switch but > >>without implying that it can be changed dynamically at runtime. > >>+module_param_named(scheduler_override, i915.scheduler_override, int, 0600); > >>+MODULE_PARM_DESC(scheduler_override, "Scheduler override mask (0 = none, 1 = direct submission [default])"); > >Is this consistent with the other *enable* booleans? > Initially there were a whole bunch of override flags for > disabling/tweaking specific bits of the scheduler's operation. Since > these extras now only exist in an internal debugging patch that is > not going to be upstreamed, I guess it probably should be simplified > to a bool rather than a flags word. Yes, later on I saw the unsigned flags. Those should be restricted to a debugfs interface, not a user parameter. module options are an invitation for the world to fiddle, and they will. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
