Re: [PATCH 2/2] drm/i915: Arm the unclaimed mmio debugs on suspend path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 08, 2016 at 03:51:20PM +0200, Mika Kuoppala wrote:
> If we go into suspend with unclaimed access detected,
> it would be nice to catch that access on a next suspend path.
> So instead of just notifying about it, arm the unclaimed
> mmio checks on suspend side.
> 
> We want to keep the asymmetry on resume, as if it was
> on resume path, it was not driver that is responsible so
> no point in arming mmio debugs.
> 
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I actually even like the extra DRM_ERROR here. Driver unload is another
candidate for

  if (intel_uncore_unclaimed_mmio(dev_priv))
	DRM_ERROR("Unclaimed access detected prior to unload\n");

Might as well tickle the CI if nothing else.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux