Right now there are 3 possible functions, update_plane that's only used by sprites, disable_plane which may be called during plane disable, and commit_plane which may call either. This is a bit messy and unclear. Make update_plane only be called when the plane is visible, and disable_plane whenever it's not. commit_plane will be removed to reduce confusion. This makes it easier to put the vma in plane_state. Maarten Lankhorst (7): drm/i915: Use passed plane state for sprite planes, v4. drm/i915: Do not use commit_plane for sprite planes. drm/i915: Remove some visibility checks from intel_crtc_update_cursor. drm/i915: Make disable_cursor_plane similar to commit_cursor_plane. drm/i915: Use the plane state for cursor updates. drm/i915: Use plane state for primary plane updates. drm/i915: Remove commit_plane function pointer. drivers/gpu/drm/i915/i915_drv.h | 3 - drivers/gpu/drm/i915/intel_atomic_plane.c | 10 +- drivers/gpu/drm/i915/intel_display.c | 355 +++++++++++++----------------- drivers/gpu/drm/i915/intel_drv.h | 12 +- drivers/gpu/drm/i915/intel_sprite.c | 129 +++++------ 5 files changed, 224 insertions(+), 285 deletions(-) -- 2.1.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
