On Sat, Jan 02, 2016 at 03:41:29PM +0200, Jani Nikula wrote: > On Thu, 31 Dec 2015, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > > On Thu, Dec 31, 2015 at 08:31:45AM +0530, Kannan, Vandana wrote: > >> When I submitted the PPS patch in April, I got an input from Jani to > >> not make changes in i915_suspend.c as it was to become obsolete. > >> Below mail for your reference. > >> > >> Jani, > >> Does your initial comment still hold good? > > > > I don't think not touching i915_suspend.c at all is an option since that > > means that the current code will try to read/write registers that simply > > don't exist on the platform. Based on Jani's comment, maybe we should > > just be adding BXT to the list of platforms we don't do any PP > > save/restore on? > > Not touching the registers in i915_suspend.c for BXT was what I meant, > but probably failed at expressing it. The encoder/connector hooks should > cover this, and if not, should be updated to cover this. The big hammer > suspend/resume in i915_suspend.c is oblivious to most modeset state and > is unable to do anything clever. Hm, I thought it died already? What's keeping the pp code in i915_suspend.c on life-support? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
