On Tue, Jan 05, 2016 at 02:54:31PM +0100, Daniel Vetter wrote: > On Mon, Jan 4, 2016 at 4:05 PM, Ville Syrjälä > <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > I think what we really need here is some kind of > > intel_display_power_get_unless_zero() thing. We need to make sure not > > only that the rpm reference is held when reading out the state, but also > > that the relevant power well(s) remain enabled while we're reading out > > the state. > > Yeah, we need to check whether a given piece of hw is enabled or not. > All the get_hw_state funcs do that, using > intel_display_power_is_enabled. But it looks like > intel_ddi_get_hw_state partially gets this wrong. That would also > address the same backtrace in module unload. Tried __only__ this patch but it doesn't fix the trace in driver unload, had the same hunch.... > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
