Re: [PATCH 01/10] drm/i915: Allow use of get_dma_address for stolen backed objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 22, 2015 at 10:23:11AM +0000, Tvrtko Ursulin wrote:
> 
> 
> On 22/12/15 06:20, ankitprasad.r.sharma@xxxxxxxxx wrote:
> >From: Ankitprasad Sharma <ankitprasad.r.sharma@xxxxxxxxx>
> >
> >i915_gem_object_get_dma_address function is used to retrieve the dma address
> >of a particular page so as to map it in a given GTT entry for CPU access.
> >This function would be used for stolen backed objects also for tasks like
> >pwrite,  clearing of the pages etc. So the obj->get_page.sg needs to be
> >initialized for the stolen objects also.
> >
> >Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@xxxxxxxxx>
> >---
> >  drivers/gpu/drm/i915/i915_gem_stolen.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> >diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> >index 598ed2f..5384767 100644
> >--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> >+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> >@@ -569,6 +569,9 @@ _i915_gem_object_create_stolen(struct drm_device *dev,
> >  	if (obj->pages == NULL)
> >  		goto cleanup;
> >
> >+	obj->get_page.sg = obj->pages->sgl;
> >+	obj->get_page.last = 0;
> >+
> >  	i915_gem_object_pin_pages(obj);
> >  	obj->stolen = stolen;
> >
> >
> 
> As the last time,
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Please do pull in r-b on reposting patches, if you haven't changed the
patch significant (err on the side of caution, if you have made logic
changes either drop the r-b, or note that the r-b was for a previous
version (only if minor changes again)).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux