On Thu, Dec 17, 2015 at 09:25:50PM +0200, Joonas Lahtinen wrote: > Add helpers to reduce the amount of noise. Use the i915.debug parameter > introduced in the previous patch to decide on whether to display all > debug messages or just ones that are meaningful to end user. > > Take for example the CI environment, we want to see all possible warning > messages even though the system continues to operate. Opposite to that is > environment in daily use, repeating errors should be displayed once to > indicate the need for a bug report, but if the machine continues to work, > we should not spam the user continuously. One thing, if we have a helper that we think will be generally useful (outside of our module), we have taken the liberty in the past in giving it a non-specific name, e.g. WARN_RECUR(); That would mean we would use WARN_RECUR(cond, i915.debug, "foo has barred\n")) instead. The theory being is that if it is useful we can then lift it to the core. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
