Re: [PATCH] drm/i915: mdelay(10) considered harmful

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



%s/cpy/cpu

Reviewed-by: Sonika Jindal <sonika.jindal@xxxxxxxxx>

On 12/12/2015 12:14 AM, Daniel Vetter wrote:
I missed this myself when reviewing

commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <sonika.jindal@xxxxxxxxx>
Date:   Tue Sep 15 09:44:20 2015 +0530

     drm/i915: Check live status before reading edid

Long sleeps like this really shouldn't waste cpy cycles spinning.

Cc: Sonika Jindal <sonika.jindal@xxxxxxxxx>
Cc: "Wang, Gary C" <gary.c.wang@xxxxxxxxx>
Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index c3978bad5ca0..b0a5a883227c 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1397,7 +1397,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
  	while (!live_status && --retry) {
  		live_status = intel_digital_port_connected(dev_priv,
  				hdmi_to_dig_port(intel_hdmi));
-		mdelay(10);
+		msleep(10);
  	}
if (!live_status)

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux