On Fri, Dec 11, 2015 at 05:26:19PM +0100, Daniel Vetter wrote: > On Fri, Dec 11, 2015 at 02:59:09PM +0000, Nick Hoath wrote: > > Swap the order of context & engine cleanup, so that it is now > > contexts, then engines. > > This allows the context clean up code to do things like confirm > > that ring->dev->struct_mutex is locked without a NULL pointer > > dereference. > > This came about as a result of the 'intel_ring_initialized() must > > be simple and inline' patch now using ring->dev as an initialised > > flag. > > Rename the cleanup function to reflect what it actually does. > > Also clean up some very annoying whitespace issues at the same time. > > > > v2: Also make the fix in i915_load_modeset_init, not just > > in i915_driver_unload (Chris Wilson) > > > > Signed-off-by: Nick Hoath <nicholas.hoath@xxxxxxxxx> > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Cc: David Gordon <david.s.gordon@xxxxxxxxx> > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Queued for -next, thanks for the patch. Well looked at BAT results still in time before pushing and dropped. Sounds like you&Mika are looking into what's going on here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx