On Fri, Dec 11, 2015 at 03:35:36PM +0000, Rob Bradford wrote: > On Fri, 2015-12-11 at 16:01 +0530, Dhanya Pillai wrote: > > + /*Enable red planes and apply unit gamma*/ > > + fb_color.red = 1; > > + fb_color.green =0; > > + fb_color.blue = 0; > > + unit_gamma = 0; /*0 -> white 1->black*/ > > Take the CRC here too, as reference_red and check that crc_white != > reference_red. (i.e. check its changed) Since there's the (fairly minimal) chance that CRCs might collide the igt library only exports helpers to check for equality, not for inequality. We do have a basic sanity testcase in BAT which makes sure that CRCs are somewhat sane and do change as expected though. But in checks it feels a bit like an unsound validation approach to me, so I just leave out all the "have things changed" checks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
