On Mon, Dec 07, 2015 at 04:02:38PM +0100, Thierry Reding wrote: > On Fri, Dec 04, 2015 at 09:46:07AM +0100, Daniel Vetter wrote: > > @@ -140,12 +352,48 @@ struct drm_display_mode { > > int crtc_vsync_end; > > int crtc_vtotal; > > > > - /* Driver private mode info */ > > + /** > > + * @private: > > + * > > + * Pointer for driver private data. This can only be used for mode > > + * objects passed to drivers in modeset operations. It shouldn't be used > > + * by atomic drivers since they can store any additional data by > > + * subclassing state structures. > > + */ > > int *private; > > Off-topic: Any reasons why this is int * and not void *? Was added like that years ago. Iirc no one ever used this at all, so maybe we should just nuke it. With atomic state structures we have a much better solution now. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx