On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/drm_atomic_helper.c | 30 ++++++++++++++++++++++++++---- > include/drm/drm_atomic_helper.h | 2 ++ > 2 files changed, 28 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index cee31d43cd1c..5d23f818faec 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -2359,6 +2359,28 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane, > EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state); > > /** > + * __drm_atomic_helper_connector_reset - default ->reset hook for connectors That's misleading because you can't use this as a ->reset() hook as-is. Maybe something like this would be better as a synopsis: __drm_atomic_helper_connector_reset - reset connector state Then the description below gives the details about what it does and when to use it, which looks fine to me. > + * @connector: drm connector > + * @conn_state: connector state to assign > + * > + * Initializes conn_state and assigns it to connector->state, usually > + * required at when initializing the drivers or when called from the s/required at/required/ Thierry
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
