Re: [PATCH i-g-t] tests/pm_rpm: Don't compare edid blob IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 01, 2015 at 05:37:40PM +0100, Daniel Vetter wrote:
> The kernel is free to allocate blob ids however it wants to. And also
> to reallocate them whenever it sees fit. The only thing we are allowed
> to compare is the length and the actual date.
> 
> Removing this bogus check makes drm-resources-equal on my snb.
> 
> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90546

Paulo, can you please ack? This seems to fail all over.
-Daniel

> ---
>  tests/pm_rpm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 37aef96ed267..55fdb31cb723 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -512,7 +512,6 @@ static void assert_drm_edids_equal(drmModePropertyBlobPtr e1,
>  		return;
>  	igt_assert(e1 && e2);
>  
> -	COMPARE(e1, e2, id);
>  	COMPARE(e1, e2, length);
>  
>  	igt_assert(memcmp(e1->data, e2->data, e1->length) == 0);
> -- 
> 2.1.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux