On 20 November 2015 at 13:55, Ville Syrjälä
<ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Thu, Nov 19, 2015 at 09:20:16AM -0800, clinton.a.taylor@xxxxxxxxx wrote:
>> +static int skl_modeset_calc_cdclk(struct drm_atomic_state *state)
>> +{
>> + struct drm_i915_private *dev_priv = to_i915(state->dev);
>> + int max_pixclk = ilk_max_pixel_rate(state);
>> + int cdclk;
>> + uint32_t linkrate;
>> +
>> + linkrate = (I915_READ(DPLL_CTRL1) &
>> + DPLL_CTRL1_LINK_RATE_MASK(SKL_DPLL0)) >> 1;
>
> I don't think we should read this from the hardware here. Instead
> we should stash the proper vco somewhere under dev_priv.
In state rather than dev_priv, surely?
Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
