On 20 November 2015 at 08:21, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Thu, 19 Nov 2015, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> On Thu, Nov 19, 2015 at 06:26:23PM +0000, Daniel Stone wrote: >>> Surely gcc's DCE pass will trivially eliminate this? >> >> Dunno. But I rather dislike having code in headers anyway. > > Agreed, particularly for long ones like this. Please just drop the > static. Purple it is; re-sent. Augmented commit message explains why it can't live in i915_debugfs.c. Cheers, Daniel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
