On Thu, Nov 05, 2015 at 11:03:38AM +0000, Chris Wilson wrote: > On Wed, Nov 04, 2015 at 11:20:07PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > When register type safety happens, we can't just try to emit the > > register itself to the ring. Instead we'll need to extract the > > offset from it first. Add some convenience functions that will do > > that. > > > > v2: Convert MOCS setup too > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > The only insane thing about this patch is the stupid ring emission API. One extra idea just popped to my mind. Should I maybe make the emit_reg() take the value too and emit both the reg offset and value? They always come in pairs after all. > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
