On Wed, Nov 04, 2015 at 11:20:14PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Add 'uint32_t offset' to the uncore register access functions. For now > it's the same as 'reg', but once type safety gets added 'reg' will be > the type safe register variable and 'offset' the raw offset. I presume this is patch 29? (I don't see patch 29/29 :( But when did we start using off_t? Why would we use a uAPI typedef for an internal type? I can't wait for you to kill it with fire. We are mixing lots of uint32_t/u32 here. But the premise of the patch is sound. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
