On mån, 2015-11-02 at 16:50 +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2015 at 03:24:15PM +0100, Robert Fekete wrote: > > Adds clarification of the rotation property bits. I.e. rotation is > > Counter clockwise and that reflects are applied before any rotation. > > > > Signed-off-by: Robert Fekete <robert.fekete@xxxxxxxxxxxxxxx> > > --- > > include/drm/drm_crtc.h | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index 3f0c6909dda1..45334fa0cb10 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -85,7 +85,11 @@ static inline uint64_t I642U64(int64_t val) > > return (uint64_t)*((uint64_t *)&val); > > } > > > > -/* rotation property bits */ > > +/* > > + * Rotation property bits. Rotate-(degrees) > > the "rotate-" and "reflect-" things were supposed to be the names of the > property bits. I guess some quotes around them would have been good. > > In any case, I tink here we should refer to the define names. eg > "DRM_ROTATE_<degrees> rotates the image by the ..." Thanks for noticing. You are absolutely right, V2 coming up in a sec. > > rotates the image by the specified > > + * amount in degrees in counter clockwise direction. reflect-x and reflect-y > > same here with > "DRM_REFLECT_X and DRM_REFLECT_Y ..." Yes! > > + * reflects the image along the specified axis prior to rotation > > + */ > > #define DRM_ROTATE_MASK 0x0f > > #define DRM_ROTATE_0 0 > > #define DRM_ROTATE_90 1 > > -- > > 1.9.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > -- BR /Robert Fekete Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
