Next iteration of these fixes, taking into account the additional issues discovered in the recent exchange with Ville (this series is in-reply-to that thread): * Patch 1 now with Reviewed-by tag by Ville (thanks!), moved to the front of the series. * Patch 2 is new, fixes a double unref of the bo in a failure path of intelfb_alloc, spotted by Ville. * Patch 3 is another attempt to eliminate the deadlocks in intelfb_alloc and intelfb_create, patch originally by Tvrtko. New in v6: Avoid unrefing the fb if it's an ERR_PTR, replace drm_framebuffer_remove with drm_framebuffer_unreference (Daniel). * Patch 4 is new, plugs leak of a struct intel_fbdev in intelfb_create. Not sure if I made the right call in the case where the fb was inherited from BIOS, comments welcome. (I decided to leave the fb as is and limp on. Alternative would be to call drm_framebuffer_remove to free the memory occupied by the fb and disable the crtc; the fbcon will be unusable anyway at this point and if X11 is able to start up without errors, it should be able to reinitialize the crtc.) Browsable on GitHub: https://github.com/l1k/linux/commits/intel_fbdev_fixes Lukas Wunner (3): drm/i915: On fb alloc failure, unref gem object where it gets refed drm/i915: Fix double unref in intelfb_alloc failure path drm/i915: Fix error handling in intelfb_create Tvrtko Ursulin (1): drm/i915: Fix failure paths around initial fbdev allocation drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++------- drivers/gpu/drm/i915/intel_fbdev.c | 38 +++++++++++++++++++++++------------- 2 files changed, 38 insertions(+), 21 deletions(-) -- 1.8.5.2 (Apple Git-48) _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
