On Thu, Oct 15, 2015 at 02:31:09PM +0200, Daniel Vetter wrote: > > On Thu, Oct 15, 2015 at 12:51 AM, Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx> wrote: > > On HSW the crc differs between black and disabled primary planes, causing an > > assert to fail in the kms_universal_plane test. It seems that gamma correction > > and color space conversion are causing the black primary plane case to result in > > a brighter color than the disabled primary plane case. > > > > Keep gamma and CSC bits enabled for plane disable path on HSW. > > > > v2: Avoid use of RMW > > Keep path unchanged for non-HSW users > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89331 > > Testcase: igt/kms_universal_plane/universal-plane-pipe-A-functional > > Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx> > > With big discussions please add everyone who participated (Ville, Chris, > Jani, me) to the cc list of the sob section of the patch when doing a new > revisions. > > Bob did something eerily similarly a while ago to fix crc failures: > > http://lists.freedesktop.org/archives/intel-gfx/2015-August/074657.html > http://lists.freedesktop.org/archives/intel-gfx/2015-August/074828.html > > Unfortunately those patches did go nowhere :( Related? Those seem to be for active plane cases. I'll go review them... -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
