On Fri, Oct 09, 2015 at 07:19:16PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > gem_mmap__{cpu,gtt,wc}() already has the assert built in, so replace > __gem_mmap__{cpu,gtt,wc}() + igt_assert() with it. > > Mostly done with coccinelle, with some manual help: > @@ > identifier I; > expression E1, E2, E3, E4, E5, E6; > @@ > ( > - I = __gem_mmap__gtt(E1, E2, E3, E4); > + I = gem_mmap__gtt(E1, E2, E3, E4); > ... > - igt_assert(I); > | > - I = __gem_mmap__cpu(E1, E2, E3, E4, E5); > + I = gem_mmap__cpu(E1, E2, E3, E4, E5); > ... > - igt_assert(I); > | > - I = __gem_mmap__wc(E1, E2, E3, E4, E5); > + I = gem_mmap__wc(E1, E2, E3, E4, E5); > ... > - igt_assert(I); > ) > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Looks like by the end we miss a few asserts (a few too many __gem_mmap left over), but that is just a continuation of the state of affairs. Series lgtm, Stochastically-reviwewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx