Re: [PATCH 8/8] drm/i915: NULL check of unpin_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/10/2015 09:39, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 08:46:31AM +0100, Chris Wilson wrote:
On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote:
Avoid NULL pointer exceptions in the display driver for certain critical cases
when unpin_work has turned out to be NULL.

Nope, the machine reached a point where it cannot possibly reach, we
want the OOPS.

Yeah this looks funky ... how did you get to that state? If it indeed
blows up in testing then we'd need at least a WARN_ON (and hopefully some
ideas what's going wrong).
-Daniel


I have no idea but I know that it blew up my machine and ended my test ahead of time. Adding this check allows me to test for 12+ hours, which is what I wanted to do.

Sure, I'll add a WARN_ON. I don't know how much time I have to investigate the root cause considering the whole TDR upstreaming situation.

Thanks,
Tomas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux