On Thu, Oct 08, 2015 at 04:12:31PM +0100, Michel Thierry wrote: > On 10/8/2015 3:37 PM, Tvrtko Ursulin wrote: > >From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > > >commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > >Author: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > >Date: Mon Oct 5 13:26:36 2015 +0100 > > > > drm/i915: Clean up associated VMAs on context destruction > > > >Introduced a wrong assumption that all contexts have a ppgtt > >instance. This is not true when full PPGTT is not active so > >remove the WARN_ON_ONCE from the context cleanup code. > > Aliasing ppgtt? (for the record, I tried with enable_ppgtt=1 while > reviewing the patch and didn't see the warning... maybe I didn't try > hard enough). We create a context per-fd on all platforms, as in it we store user specific information (such as hangstats, process identifiers etc). Think of a context as a view of driver state not just GPU state. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
